I did not see any other replies but I understand your holding. I personally don't think crashing in the assert itself provides any value since difference in behaviour between debug and release is bad (IMHO). How about: ASSERT(location_ != NULL); // as before ASSERT(location_ && reinterpret_cast<Address>(*location_) != kHandleZapValue);
Best of both worlds? Sverrir On Fri, May 15, 2009 at 2:13 AM, <[email protected]> wrote: > As Søren and Kevin replied, dereferencing a null handle is going to > crash anyway, so I'd like to keep this a two separate ASSERTS so it is > easy to see which one of the conjuncts gets hit. > > > > http://codereview.chromium.org/113409 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
