We clearly have different philosophies. I would say "*Since* this completely disappears in the generated assembly code, is there any reason not to make it look nicer?"
Seriously, though, I do cringe whenever we break the Register abstraction by writing a struct with one field. That's just one more site that has to be updated if we ever want to change it. On Fri, May 15, 2009 at 5:44 PM, <[email protected]> wrote: > > > http://codereview.chromium.org/113402/diff/1/6 > File src/arm/virtual-frame-arm.h (right): > > http://codereview.chromium.org/113402/diff/1/6#newcode134 > Line 134: Register temp = { i }; > On 2009/05/14 15:41:49, Kevin Millikin wrote: > > It might be better to overload RegisterAllocator::Unuse to have an int > (and call > > it in the Register version). > > This completely disappears in the generated assembly code, so is it > worthwhile adding the extra (inlined) functions just to make this look > nicer? > > http://codereview.chromium.org/113402 > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
