Author: [email protected]
Date: Fri May 15 21:38:46 2009
New Revision: 1981
Modified:
branches/1.1/ChangeLog
branches/1.1/src/api.cc
branches/1.1/src/codegen-ia32.cc
Log:
Apply r1978 to the 1.1 branch.
- Fix handling when compiling count operations.
NOTE: I didn't include the #if debug block move, since
it doesn't seem relevant to the Chrome 172 release.
BUG= http://crbug.com/12054
TBR= iposva,ager
Review URL: http://codereview.chromium.org/115439
Modified: branches/1.1/ChangeLog
==============================================================================
--- branches/1.1/ChangeLog (original)
+++ branches/1.1/ChangeLog Fri May 15 21:38:46 2009
@@ -1,3 +1,8 @@
+2009-05-15: Version 1.1.10.12
+
+ Fix http://crbug.com/12054. Fix numeric overflow handling when
compiling
+ count operations in CodeGenerator::VisitCountOperation.
+
2009-04-15: Version 1.1.10
Fixed crash bug that occurred when loading a const variable in the
Modified: branches/1.1/src/api.cc
==============================================================================
--- branches/1.1/src/api.cc (original)
+++ branches/1.1/src/api.cc Fri May 15 21:38:46 2009
@@ -2373,7 +2373,7 @@
const char* v8::V8::GetVersion() {
- return "1.1.10.11";
+ return "1.1.10.12";
}
Modified: branches/1.1/src/codegen-ia32.cc
==============================================================================
--- branches/1.1/src/codegen-ia32.cc (original)
+++ branches/1.1/src/codegen-ia32.cc Fri May 15 21:38:46 2009
@@ -4856,9 +4856,9 @@
// successfully allocate a temporary byte register.
if (tmp.is_valid()) {
__ setcc(overflow, tmp.reg());
- __ or_(Operand(value.reg()), tmp.reg());
+ __ or_(Operand(tmp.reg()), value.reg());
+ __ test(tmp.reg(), Immediate(kSmiTagMask));
tmp.Unuse();
- __ test(value.reg(), Immediate(kSmiTagMask));
deferred->enter()->Branch(not_zero, &value, not_taken);
} else { // Otherwise we test separately for overflow and smi check.
deferred->enter()->Branch(overflow, &value, not_taken);
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
