LGTM
http://codereview.chromium.org/113522/diff/1/5 File src/objects.h (right): http://codereview.chromium.org/113522/diff/1/5#newcode3669 Line 3669: // buffer. Clever. I suggest the following comment: Each character represents 32 bits. M is the map, L is the length/hash, B and S are the buffer and start in a sliced string. 1 and 2 are the first and second parts of a cons string. 32 bit Slice: MLBS 32 bit Cons: ML12 64 bit Slice: MMLSBB 64 bit Cons: MML 1122 http://codereview.chromium.org/113522/diff/1/5#newcode4167 Line 4167: static const int kSize = kInternalFieldCountOffset + kPointerSize; Good catch. http://codereview.chromium.org/113522 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
