LGTM
http://codereview.chromium.org/115462/diff/1005/1015 File src/debug.cc (right): http://codereview.chromium.org/115462/diff/1005/1015#newcode553 Line 553: HandleScope scope; Why do you need to create this handle to the script? http://codereview.chromium.org/115462/diff/1005/1015#newcode1570 Line 1570: // Perform GC to get unreferenced scripts evicted from the cache before before before before -> before http://codereview.chromium.org/115462/diff/1005/1010 File src/debug.h (right): http://codereview.chromium.org/115462/diff/1005/1010#newcode151 Line 151: // the hash map holding the cache is the script id. I would just write "The key used in the cache is the script id." http://codereview.chromium.org/115462 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
