Reviewers: William Hesse, Message: Quick review.
Description: X64: Fixups in heap-test.cc to make it compile in X64 mode. Please review this at http://codereview.chromium.org/113574 Affected files: M src/x64/assembler-x64.cc M test/cctest/test-heap.cc Index: src/x64/assembler-x64.cc diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc index 0efb34a841b7bc2fe281715983fbb01f02762057..fb3bce2383dde74534f08648d540f98177d197ff 100644 --- a/src/x64/assembler-x64.cc +++ b/src/x64/assembler-x64.cc @@ -105,6 +105,12 @@ Assembler::~Assembler() { UNIMPLEMENTED(); } + +void Assembler::nop() { + UNIMPLEMENTED(); +} + + void BreakLocationIterator::ClearDebugBreakAtReturn() { UNIMPLEMENTED(); } @@ -352,6 +358,12 @@ void CpuFeatures::Probe() { UNIMPLEMENTED(); } + +bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo*) { + UNIMPLEMENTED(); + return false; +} + void Debug::GenerateCallICDebugBreak(MacroAssembler* a) { UNIMPLEMENTED(); } Index: test/cctest/test-heap.cc diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc index e35ac5fbaf35f95e78866a4ba20e1dbf8f7f5d16..4e924215b958c5fac318f232f457d2a9fc0e04b5 100644 --- a/test/cctest/test-heap.cc +++ b/test/cctest/test-heap.cc @@ -315,7 +315,7 @@ static bool WeakPointerCleared = false; static void TestWeakGlobalHandleCallback(v8::Persistent<v8::Value> handle, void* id) { USE(handle); - if (1234 == reinterpret_cast<int>(id)) WeakPointerCleared = true; + if (1234 == reinterpret_cast<intptr_t>(id)) WeakPointerCleared = true; } @@ -385,7 +385,7 @@ TEST(WeakGlobalHandlesMark) { static void TestDeleteWeakGlobalHandleCallback( v8::Persistent<v8::Value> handle, void* id) { - if (1234 == reinterpret_cast<int>(id)) WeakPointerCleared = true; + if (1234 == reinterpret_cast<intptr_t>(id)) WeakPointerCleared = true; handle.Dispose(); } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
