LGTM. On Tue, May 19, 2009 at 10:25 PM, <[email protected]> wrote: > Reviewers: Kasper Lund, > > Description: > Increase the size of VirtualFrame members to allow a larger number of > parameters, stack-allocated locals, or expression stack elements. > > > Please review this at http://codereview.chromium.org/115535 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/virtual-frame-arm.h > M src/ia32/virtual-frame-ia32.h > M src/x64/virtual-frame-x64.h > > > Index: src/ia32/virtual-frame-ia32.h > =================================================================== > --- src/ia32/virtual-frame-ia32.h (revision 2001) > +++ src/ia32/virtual-frame-ia32.h (working copy) > @@ -401,20 +401,20 @@ > ZoneList<FrameElement> elements_; > > // The number of frame-allocated locals and parameters respectively. > - int16_t parameter_count_; > - int16_t local_count_; > + int parameter_count_; > + int local_count_; > > // The index of the element that is at the processor's stack pointer > // (the esp register). > - int16_t stack_pointer_; > + int stack_pointer_; > > // The index of the element that is at the processor's frame pointer > // (the ebp register). > - int16_t frame_pointer_; > + int frame_pointer_; > > // The index of the register frame element using each register, or > // kIllegalIndex if a register is not on the frame. > - int16_t register_locations_[kNumRegisters]; > + int register_locations_[kNumRegisters]; > > // The index of the first parameter. The receiver lies below the first > // parameter. > Index: src/x64/virtual-frame-x64.h > =================================================================== > --- src/x64/virtual-frame-x64.h (revision 2001) > +++ src/x64/virtual-frame-x64.h (working copy) > @@ -401,20 +401,20 @@ > ZoneList<FrameElement> elements_; > > // The number of frame-allocated locals and parameters respectively. > - int16_t parameter_count_; > - int16_t local_count_; > + int parameter_count_; > + int local_count_; > > // The index of the element that is at the processor's stack pointer > // (the esp register). > - int16_t stack_pointer_; > + int stack_pointer_; > > // The index of the element that is at the processor's frame pointer > // (the ebp register). > - int16_t frame_pointer_; > + int frame_pointer_; > > // The index of the register frame element using each register, or > // kIllegalIndex if a register is not on the frame. > - int16_t register_locations_[kNumRegisters]; > + int register_locations_[kNumRegisters]; > > // The index of the first parameter. The receiver lies below the first > // parameter. > Index: src/arm/virtual-frame-arm.h > =================================================================== > --- src/arm/virtual-frame-arm.h (revision 2001) > +++ src/arm/virtual-frame-arm.h (working copy) > @@ -380,20 +380,20 @@ > ZoneList<FrameElement> elements_; > > // The number of frame-allocated locals and parameters respectively. > - int16_t parameter_count_; > - int16_t local_count_; > + int parameter_count_; > + int local_count_; > > // The index of the element that is at the processor's stack pointer > // (the sp register). > - int16_t stack_pointer_; > + int stack_pointer_; > > // The index of the element that is at the processor's frame pointer > // (the fp register). > - int16_t frame_pointer_; > + int frame_pointer_; > > // The index of the register frame element using each register, or > // kIllegalIndex if a register is not on the frame. > - int16_t register_locations_[kNumRegisters]; > + int register_locations_[kNumRegisters]; > > // The index of the first parameter. The receiver lies below the first > // parameter. > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
