LGTM.

http://codereview.chromium.org/113622/diff/1/6
File src/top.h (right):

http://codereview.chromium.org/113622/diff/1/6#newcode263
Line 263: static Handle<Context> calling_global_context();
I'd like to rename this to GetCallingGlobalContext or something. It's
weird that it uses the accessor naming convention. We should consider
changing some of the other methods in Top too, but you don't have to do
that now.

http://codereview.chromium.org/113622

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to