LGTM, but it would be extra nice with command line flag to disable the compilation cache altogether.
http://codereview.chromium.org/113625/diff/1/5 File src/compilation-cache.cc (right): http://codereview.chromium.org/113625/diff/1/5#newcode292 Line 292: enabled = true; It would be great if you could add a flag to control this behavior too - so we could always disable the compilation cache if we want to. http://codereview.chromium.org/113625/diff/1/5#newcode293 Line 293: Clear(); Is this Clear really meaningful? http://codereview.chromium.org/113625/diff/1/4 File src/debug.cc (right): http://codereview.chromium.org/113625/diff/1/4#newcode2177 Line 2177: // Disable the compilation cache when the debugger is active. I guess SetEventListener and SetMessageHandler are used to both activate and deactivate the debugger? http://codereview.chromium.org/113625 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
