It looks like pc(), a byte*, is being used to hold an int offset, which
is being manipulated.  See comment.

Otherwise, LGTM.


http://codereview.chromium.org/115567/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/115567/diff/1/2#newcode221
Line 221: int32_t* p = reinterpret_cast<int32_t*>(it.rinfo()->pc());
pc() is a byte*.  If you want to manipulate it as an int, cast it to
intptr_t, but I think you can do what you want directly:
it.rinfo()->set_pc( it.rinfo()->pc() - pc_delta );

http://codereview.chromium.org/115567

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to