ARM builtins updated as well.
http://codereview.chromium.org/113634/diff/1/8 File src/builtins.cc (right): http://codereview.chromium.org/113634/diff/1/8#newcode398 Line 398: // API that support calls. The object can be called as either a constructor On 2009/05/20 12:23:28, Mads Ager wrote: > In all of these comments, I would remove the "that supports calls". Done. http://codereview.chromium.org/113634/diff/1/8#newcode407 Line 407: ASSERT(!CalledAsConstructor()); On 2009/05/20 13:00:18, Christian Plesner Hansen wrote: > Nit: I'd move the assert to the very top of the function, before doing anything > else. Done. http://codereview.chromium.org/113634/diff/1/9 File src/contexts.h (right): http://codereview.chromium.org/113634/diff/1/9#newcode94 Line 94: call_as_constructor_delegate) \ On 2009/05/20 12:23:28, Mads Ager wrote: > Indentation seems slightly off here? Done. http://codereview.chromium.org/113634/diff/1/12 File src/execution.h (right): http://codereview.chromium.org/113634/diff/1/12#newcode133 Line 133: static Handle<Object> GetConstructorDelegate(Handle<Object> object); On 2009/05/20 12:23:28, Mads Ager wrote: > Add comment like the one above? Done. http://codereview.chromium.org/113634 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
