LGTM 2009/5/22 <[email protected]>: > Reviewers: Erik Corry, > > Description: > Do not ignore the result from calls to write(). This avoids a warning > from newer gcc versions. > > Please review this at http://codereview.chromium.org/115698 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/d8-posix.cc > > > Index: src/d8-posix.cc > =================================================================== > --- src/d8-posix.cc (revision 2025) > +++ src/d8-posix.cc (working copy) > @@ -280,7 +280,10 @@ > // Only get here if the exec failed. Write errno to the parent to tell > // them it went wrong. If it went well the pipe is closed. > int err = errno; > - write(exec_error_fds[kWriteFD], &err, sizeof(err)); > + int bytes_written; > + do { > + bytes_written = write(exec_error_fds[kWriteFD], &err, sizeof(err)); > + } while (bytes_written == -1 && errno == EINTR); > // Return (and exit child process). > } > > > >
-- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
