LGTM, but it would be nice to simplify AddAll and make sure that repeated access to stuff like other.length_ is fast. Maybe you should extend test-list.cc to make sure AddAll works as intended?
http://codereview.chromium.org/115705/diff/1003/1006 File src/list-inl.h (right): http://codereview.chromium.org/115705/diff/1003/1006#newcode49 Line 49: int result_length = length_ + other.length_; There's a mixture of other.length() and other.length_ access in this function. http://codereview.chromium.org/115705/diff/1003/1007 File src/virtual-frame.cc (right): http://codereview.chromium.org/115705/diff/1003/1007#newcode40 Line 40: : elements_(original->elements_.capacity()), Maybe length would be enough here? http://codereview.chromium.org/115705 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
