Reviewers: Søren Gjesse,

Description:
When message handler is set to NULL and there is no debugger listener
the debugger is unloaded immediately unless it's entered, in which case
it will be unloaded when last instance of EnterDebugger is destroyed.

Without the change the debugger may crash as
Debugger::EventActive(v8::Break) called from OnDebugBreak may clear
current debugger context.

Also when compilation cache was enabled debugger could fail on second
attach for the same reason(see
AfterCompileMessageWhenMessageHandlerIsReset).

BUG=12404

Please review this at http://codereview.chromium.org/115709

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     src/debug.h
   M     src/debug.cc
   M     test/cctest/test-debug.cc



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to