Minor comment-related comments :) The solution seems reasonable but I'll leave the logics check to Soeren.
http://codereview.chromium.org/115709/diff/1003/1005 File src/debug.h (right): http://codereview.chromium.org/115709/diff/1003/1005#newcode658 Line 658: static bool debugger_unload_pending_; // Was message handler cleared? should the field comment be changed a bit? http://codereview.chromium.org/115709/diff/1003/1004 File test/cctest/test-debug.cc (right): http://codereview.chromium.org/115709/diff/1003/1004#newcode4918 Line 4918: // Tests that after compile event is sent as many times as there scripts as there scripts compiled -> as there are scripts compiled http://codereview.chromium.org/115709/diff/1003/1004#newcode4934 Line 4934: // Setting listener to should cause debugger unload. ..to NULL.. http://codereview.chromium.org/115709/diff/1003/1004#newcode4958 Line 4958: // Call f while enabeling and disabling the script break point. enabling http://codereview.chromium.org/115709/diff/1003/1004#newcode4993 Line 4993: // Call f while enabeling and disabling the script break point. ditto http://codereview.chromium.org/115709 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
