http://codereview.chromium.org/113763/diff/1/5 File src/log.cc (right):
http://codereview.chromium.org/113763/diff/1/5#newcode308 Line 308: static bool is_enabled() { On 2009/05/25 06:38:31, Søren Gjesse wrote: > How about changing this to IsEnabled() as well? This is no really an accessor. Good idea. Done. http://codereview.chromium.org/113763/diff/1/7 File test/cctest/test-func-name-inference.cc (right): http://codereview.chromium.org/113763/diff/1/7#newcode35 Line 35: using ::v8::internal::CStrVector; On 2009/05/25 06:38:31, Søren Gjesse wrote: > I must admit that I would prefer to not use "using" and either use a namespace > alias or use full namespaces, but lets keep it with "using" for now and getting > rid of the mix of "using" and namespace alias is good. Honestly, me too, because when using "using" it's good to have some auto-checker that helps to get rid of no more used imports (like the tool that track imports for Java). http://codereview.chromium.org/113763 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
