LGTM, but maybe Kevin should take a look too?
http://codereview.chromium.org/115744/diff/1/17 File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/115744/diff/1/17#newcode66 Line 66: Operand(~(Code::kFlagsTypeMask | Code::kFlagsICInLoopMask))); Why not have a constant mask for the combination of the two masks? http://codereview.chromium.org/115744/diff/1/9 File src/ic.h (right): http://codereview.chromium.org/115744/diff/1/9#newcode124 Line 124: const char* updated_from = ""); updated_from -> extra_info? http://codereview.chromium.org/115744 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
