Shouldn't this have been done via test/cctest/cctest.status? On Mon, May 25, 2009 at 12:23 PM, <[email protected]> wrote: > Reviewers: Søren Gjesse, > > Description: > Disable crashing ProfLazyMode test on ARM. > > Please review this at http://codereview.chromium.org/115760 > > Affected files: > M test/cctest/test-log.cc > > > Index: test/cctest/test-log.cc > diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc > index > 3d5d5ae8903524486b0212998a0dc2e81ba1afb0..e5d31e67d5bb3aa65befc69e46cd88e71bdf1d57 > 100644 > --- a/test/cctest/test-log.cc > +++ b/test/cctest/test-log.cc > @@ -129,6 +129,11 @@ static void CompileAndRunScript(const char *src) { > } > > > +// Exclude the following test from ARM because profiling can > +// malfunction there. > +// TODO(mikhail.naganov): Fix it. > +#ifndef V8_TARGET_ARCH_ARM > + > namespace v8 { > namespace internal { > > @@ -238,6 +243,8 @@ TEST(ProfLazyMode) { > i::FLAG_prof_auto = saved_prof_auto; > } > > +#endif // V8_TARGET_ARCH_ARM > + > > static inline bool IsStringEqualTo(const char* r, const char* s) { > return strncmp(r, s, strlen(r)) == 0; > @@ -701,5 +708,4 @@ TEST(EquivalenceOfLoggingAndTraversal) { > i::FLAG_always_compact = saved_always_compact; > } > > - > #endif // ENABLE_LOGGING_AND_PROFILING > > > > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
