Reviewers: Søren Gjesse, Description: Remove ifdef from ProfLazyMode test, instead mark it in cctest.status.
Please review this at http://codereview.chromium.org/113820 Affected files: M test/cctest/cctest.status M test/cctest/test-log.cc Index: test/cctest/cctest.status diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 93e348be2ed8f02739b5e7cb2d0a9b84bb953760..a8c218016691bb878d40545a44f85f4ca8edb179 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -46,6 +46,9 @@ test-api/RegExpInterruption: SKIP test-api/OutOfMemory: SKIP test-api/OutOfMemoryNested: SKIP +# BUG(355): Test crashes on ARM. +test-log/ProfLazyMode: SKIP + [ $simulator == arm ] # BUG(271): During exception propagation, we compare pointers into the Index: test/cctest/test-log.cc diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc index f1b8c20d32b5e1ce90039418d657daea0ee42743..476421db6b7ce60d0c1ca17495f1a2b72ddead0f 100644 --- a/test/cctest/test-log.cc +++ b/test/cctest/test-log.cc @@ -129,11 +129,6 @@ static void CompileAndRunScript(const char *src) { } -// Exclude the following test from ARM because profiling can -// malfunction there. -// TODO(mikhail.naganov): Fix it. -#ifndef V8_TARGET_ARCH_ARM - namespace v8 { namespace internal { @@ -243,8 +238,6 @@ TEST(ProfLazyMode) { i::FLAG_prof_auto = saved_prof_auto; } -#endif // V8_TARGET_ARCH_ARM - static inline bool IsStringEqualTo(const char* r, const char* s) { return strncmp(r, s, strlen(r)) == 0; --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
