LGTM On Mon, May 25, 2009 at 16:55, <[email protected]> wrote:
> On 2009/05/25 14:13:43, Søren Gjesse wrote: > >> LGTM >> > > How about adding a test where the accessor throws an exception? >> > > On top of this we also needs to handle interceptors. They are used in >> > various > >> places in the binding layer, where the properties on an object are >> > dynamic, e.g. > >> frames and forms are available on the windows object as properties >> > named from > >> their id's (unless these are shadowed by global variables of the same >> > name). > > We might need to add reflective callbacks to the interceptors to >> > create mirror > >> objects or maybe we can implement the already defined enumerate >> > function on the > >> interceptor in the binding layer. Properties from interceptors are >> > currently not > >> visible in for in as the enumerate function is not implemented. >> > Whether > >> implementing this will break compatibility I don't know. Also the >> > enumerate > >> callback might be missing some of the details we would like to include >> > in the > >> mirror objects. Of cause with interceptors there is the issue that >> > properties > >> might come and go as the interceptor function sees fit. E.g. an >> > interceptor > >> which has the property of the roman numeral of the current hour. >> > > Added a test with accessor throwing an error. You are absolutely right > that with the accessors we can inspect only standard DOM properties and > We definitely need to do something about the interceptors to inspect the > dynamic properties. > > > http://codereview.chromium.org/113821 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
