Reviewers: iposva, Description: Merge bleeding_e...@2052 to trunk.
Please review this at http://codereview.chromium.org/113833 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M src/compilation-cache.cc M src/counters.h M src/version.cc Index: src/counters.h =================================================================== --- src/counters.h (revision 2050) +++ src/counters.h (working copy) @@ -75,7 +75,7 @@ // function. min and max define the expected minimum and maximum // sample values. buckets is the maximum number of buckets // that the samples will be grouped into. - static void *CreateHistogram(const char* name, + static void* CreateHistogram(const char* name, int min, int max, size_t buckets) { Index: src/compilation-cache.cc =================================================================== --- src/compilation-cache.cc (revision 2050) +++ src/compilation-cache.cc (working copy) @@ -36,7 +36,7 @@ // The number of script generations tell how many GCs a script can // survive in the compilation cache, before it will be flushed if it // hasn't been used. - NUMBER_OF_SCRIPT_GENERATIONS = 5, + NUMBER_OF_SCRIPT_GENERATIONS = 8, // The compilation cache consists of tables - one for each entry // kind plus extras for the script generations. @@ -175,6 +175,17 @@ } } + static void* script_histogram = StatsTable::CreateHistogram( + "V8.ScriptCache", + 0, + NUMBER_OF_SCRIPT_GENERATIONS, + NUMBER_OF_SCRIPT_GENERATIONS + 1); + + if (script_histogram != NULL) { + // The level NUMBER_OF_SCRIPT_GENERATIONS is equivalent to a cache miss. + StatsTable::AddHistogramSample(script_histogram, generation - SCRIPT); + } + // Once outside the manacles of the handle scope, we need to recheck // to see if we actually found a cached script. If so, we return a // handle created in the caller's handle scope. Index: src/version.cc =================================================================== --- src/version.cc (revision 2050) +++ src/version.cc (working copy) @@ -35,7 +35,7 @@ #define MAJOR_VERSION 1 #define MINOR_VERSION 2 #define BUILD_NUMBER 5 -#define PATCH_LEVEL 0 +#define PATCH_LEVEL 1 #define CANDIDATE_VERSION false // Define SONAME to have the SCons build the put a specific SONAME into the --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
