LGTM.
http://codereview.chromium.org/113837/diff/104/109 File src/ia32/register-allocator-ia32-inl.h (right): http://codereview.chromium.org/113837/diff/104/109#newcode63 Line 63: } You could map the codes 0,1,2,3, and 7 to the range 0..4 by (i + 1) & 7, and back by (i+7) & 7. Would this be faster than the lookup tables? http://codereview.chromium.org/113837/diff/104/121 File src/ia32/virtual-frame-ia32.h (right): http://codereview.chromium.org/113837/diff/104/121#newcode152 Line 152: // Sync the range of elements in [begin, end] with memory. I am surprised that there were no uses of this that incorrectly assumed that elements[end] didn't get synced. Is this true, and was this always just an incorrect comment listing the range as not including end? http://codereview.chromium.org/113837 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
