Tobias, running short (less than a second) profiling sessions is impractical. This test ensures that sampler is running and its results are retrieved, no more. The problem is that sampler is implemented either as a signal handler or as a separate thread. I can have no guarantees from OS in what period of time it will be spawned and will start to work. So in the test I'm trying to achieve a balance between making the test to pass in a timely manner and maintaining stability.
The perfect solution would be to establish explicit synchronization between the sampler and the test, but adding facilities to code only to be used in tests doesn't seem to be practical. On Tue, May 26, 2009 at 22:46, <[email protected]> wrote: > The fix looks to me like it's just hiding the problem, not fixing it. > The crashes may be caused by an edge case which gets triggered if the > time span is short. > > http://codereview.chromium.org/115772 > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
