Lgtm

http://codereview.chromium.org/113894/diff/1001/1003
File src/jsregexp.h (right):

http://codereview.chromium.org/113894/diff/1001/1003#newcode1322
Line 1322: bool failed() { return error_message_ != NULL; }
Since this is a boolean predicate it should be 'has_failed'.

http://codereview.chromium.org/113894

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to