LGTM
http://codereview.chromium.org/115814/diff/1/3 File src/log-utils.cc (right): http://codereview.chromium.org/115814/diff/1/3#newcode43 Line 43: blocks_[0] = NewArray<char>(block_size_); Maybe add a private method AllocateBlock. http://codereview.chromium.org/115814/diff/1/3#newcode93 Line 93: blocks_[++block_index_] = NewArray<char>(block_size_); Ditto. http://codereview.chromium.org/115814/diff/1/4 File src/log-utils.h (right): http://codereview.chromium.org/115814/diff/1/4#newcode49 Line 49: // filled is returned, it is <= that 'buf_size'. Remove that http://codereview.chromium.org/115814/diff/1/7 File test/cctest/test-log-utils.cc (right): http://codereview.chromium.org/115814/diff/1/7#newcode16 Line 16: // Writes ref_buffer.length chars into dynabuf. Please add to comment that this also actually fills the ref_buffer before writing it to the dynabuf. http://codereview.chromium.org/115814 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
