Author: [email protected]
Date: Thu May 28 00:45:17 2009
New Revision: 2068
Modified:
branches/bleeding_edge/src/platform.h
Log:
Tiny fix: initialize TickSample::frames_count with 0.
I suggest that the lack of initialization causes issue 358 to happen. In
Profiler::Disengage an empty TickSample is inserted in order to wake up the
Profiler thread. Issue reporter claims that crash happens in LogTickEvent
function. My guess is that frames_couint receives a wild value.
Review URL: http://codereview.chromium.org/113939
Modified: branches/bleeding_edge/src/platform.h
==============================================================================
--- branches/bleeding_edge/src/platform.h (original)
+++ branches/bleeding_edge/src/platform.h Thu May 28 00:45:17 2009
@@ -493,7 +493,7 @@
// TickSample captures the information collected for each sample.
class TickSample {
public:
- TickSample() : pc(0), sp(0), fp(0), state(OTHER) {}
+ TickSample() : pc(0), sp(0), fp(0), state(OTHER), frames_count(0) {}
uintptr_t pc; // Instruction pointer.
uintptr_t sp; // Stack pointer.
uintptr_t fp; // Frame pointer.
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
