Reviewers: Kevin Millikin, Description: Declare register names as static constants rather than external globals.
Please review this at http://codereview.chromium.org/119082 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/ia32/assembler-ia32.h M src/ia32/assembler-ia32.cc Index: src/ia32/assembler-ia32.cc =================================================================== --- src/ia32/assembler-ia32.cc (revision 2098) +++ src/ia32/assembler-ia32.cc (working copy) @@ -44,29 +44,6 @@ namespace internal { // ----------------------------------------------------------------------------- -// Implementation of Register - -Register eax = { 0 }; -Register ecx = { 1 }; -Register edx = { 2 }; -Register ebx = { 3 }; -Register esp = { 4 }; -Register ebp = { 5 }; -Register esi = { 6 }; -Register edi = { 7 }; -Register no_reg = { -1 }; - -XMMRegister xmm0 = { 0 }; -XMMRegister xmm1 = { 1 }; -XMMRegister xmm2 = { 2 }; -XMMRegister xmm3 = { 3 }; -XMMRegister xmm4 = { 4 }; -XMMRegister xmm5 = { 5 }; -XMMRegister xmm6 = { 6 }; -XMMRegister xmm7 = { 7 }; - - -// ----------------------------------------------------------------------------- // Implementation of CpuFeatures // Safe default is no features. Index: src/ia32/assembler-ia32.h =================================================================== --- src/ia32/assembler-ia32.h (revision 2098) +++ src/ia32/assembler-ia32.h (working copy) @@ -79,15 +79,15 @@ int code_; }; -extern Register eax; -extern Register ecx; -extern Register edx; -extern Register ebx; -extern Register esp; -extern Register ebp; -extern Register esi; -extern Register edi; -extern Register no_reg; +static const Register eax = {0}; +static const Register ecx = { 1 }; +static const Register edx = { 2 }; +static const Register ebx = { 3 }; +static const Register esp = { 4 }; +static const Register ebp = { 5 }; +static const Register esi = { 6 }; +static const Register edi = { 7 }; +static const Register no_reg = { -1 }; struct XMMRegister { @@ -100,14 +100,14 @@ int code_; }; -extern XMMRegister xmm0; -extern XMMRegister xmm1; -extern XMMRegister xmm2; -extern XMMRegister xmm3; -extern XMMRegister xmm4; -extern XMMRegister xmm5; -extern XMMRegister xmm6; -extern XMMRegister xmm7; +static const XMMRegister xmm0 = { 0 }; +static const XMMRegister xmm1 = { 1 }; +static const XMMRegister xmm2 = { 2 }; +static const XMMRegister xmm3 = { 3 }; +static const XMMRegister xmm4 = { 4 }; +static const XMMRegister xmm5 = { 5 }; +static const XMMRegister xmm6 = { 6 }; +static const XMMRegister xmm7 = { 7 }; enum Condition { // any value < 0 is considered no_condition --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
