LGTM.
http://codereview.chromium.org/119078/diff/1/2 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/119078/diff/1/2#newcode482 Line 482: if ((adr.code() & 0x8) == 0x8) { Or (adr.code() & 0x8) != 0 We use this test so often, Register should have a method for it. Perhaps Register::IsExtendedRegister(). http://codereview.chromium.org/119078/diff/1/2#newcode790 Line 790: emit(0xB8 | (dst.code() & 0x7)); // Not a ModR/M byte. We don't write that comment in other places with the same type of opcode. To match the opcode specification, "B8+ rd", better, you could write + instead of |, i.e.: 0xB8 + (dst.code() & 0x7) Perhaps introduce a function on Register returning the low-bits, so it's 0xB8 + dst.low_bits() or something similar. http://codereview.chromium.org/119078/diff/1/2#newcode1142 Line 1142: No testq(Register,Immediate)? http://codereview.chromium.org/119078 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
