One small adjustment.  Otherwise, LGTM and thanks.

http://codereview.chromium.org/118306/diff/1/2
File tools/linux-tick-processor (right):

http://codereview.chromium.org/118306/diff/1/2#newcode8
Line 8: [ -x $d8_exec ] || scons -C $D8_PATH d8
I think this second half needs to be:

scons -C $D8_PATH -Y $tools_path/.. d8

to cover the case where there is no SConstruct file in $D8_PATH (that's
my case).

http://codereview.chromium.org/118306

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to