It is really cool to now have the V8 profiler exposed in Chromium by default. Regards, Søren
On Mon, Jun 8, 2009 at 16:48, <[email protected]> wrote: > > Reviewers: pfeldman, > > Description: > Turn on DevTools Profiler. > > Works on Windows and Linux. On Mac V8's sampling doesn't work with > Chromium due to an unknown reason. > > BUG=none > TEST=none > > > Please review this at http://codereview.chromium.org/118384 > > SVN Base: svn://chrome-svn/chrome/trunk/src/ > > Affected files: > M chrome/renderer/render_process.cc > M webkit/glue/devtools/js/inspector_controller_impl.js > > > Index: webkit/glue/devtools/js/inspector_controller_impl.js > =================================================================== > --- webkit/glue/devtools/js/inspector_controller_impl.js (revision > 17852) > +++ webkit/glue/devtools/js/inspector_controller_impl.js (working > copy) > @@ -29,7 +29,7 @@ > * {...@inheritdoc}. > */ > devtools.InspectorControllerImpl.prototype.hiddenPanels = function() { > - return 'profiles,databases'; > + return 'databases'; > }; > > > @@ -149,7 +149,7 @@ > /** > * @override > */ > -devtools.InspectorControllerImpl.prototype.pauseOnExceptions = function() > { > +devtools.InspectorControllerImpl.prototype.pauseOnExceptions = function() > { > return devtools.tools.getDebuggerAgent().pauseOnExceptions(); > }; > > Index: chrome/renderer/render_process.cc > =================================================================== > --- chrome/renderer/render_process.cc (revision 17852) > +++ chrome/renderer/render_process.cc (working copy) > @@ -100,7 +100,9 @@ > > if (!command_line.HasSwitch(switches::kDisableOutOfProcessDevTools)) { > // Out of process dev tools rely upon auto break behavior. > - webkit_glue::SetJavaScriptFlags(L"--debugger-auto-break"); > + webkit_glue::SetJavaScriptFlags(L"--debugger-auto-break " > + // Enable lazy in-memory profiling. > + L"--prof --prof-lazy --logfile=*"); > } > > if (command_line.HasSwitch(switches::kEnableWatchdog)) { > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
