http://codereview.chromium.org/126200/diff/1/2
File tools/tickprocessor.js (left):

http://codereview.chromium.org/126200/diff/1/2#oldcode171
Line 171: throw e;
Hmm... Does rethrowing an exception fails in your case?

http://codereview.chromium.org/126200/diff/1/2
File tools/tickprocessor.js (right):

http://codereview.chromium.org/126200/diff/1/2#newcode490
Line 490: this.parsePos = 0;
You can move this assignment before the try block.

http://codereview.chromium.org/126200/diff/1/2#newcode493
Line 493: this.symbols = [ "", "" ];
nit: Use single quotes.

http://codereview.chromium.org/126200

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to