Reviewers: Michail Naganov, Description: Use >>> instead of >> in order to cover the full 32 bit range when handling addresses.
Please review this at http://codereview.chromium.org/125187 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M tools/codemap.js Index: tools/codemap.js =================================================================== --- tools/codemap.js (revision 2192) +++ tools/codemap.js (working copy) @@ -126,7 +126,7 @@ devtools.profiler.CodeMap.prototype.markPages_ = function(start, end) { for (var addr = start; addr <= end; addr += devtools.profiler.CodeMap.PAGE_SIZE) { - this.pages_[addr >> devtools.profiler.CodeMap.PAGE_ALIGNMENT] = 1; + this.pages_[addr >>> devtools.profiler.CodeMap.PAGE_ALIGNMENT] = 1; } }; @@ -155,7 +155,7 @@ * @param {number} addr Address. */ devtools.profiler.CodeMap.prototype.findEntry = function(addr) { - var pageAddr = addr >> devtools.profiler.CodeMap.PAGE_ALIGNMENT; + var pageAddr = addr >>> devtools.profiler.CodeMap.PAGE_ALIGNMENT; if (pageAddr in this.pages_) { return this.findInTree_(this.statics_, addr); } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
