I like your change. How serious is the performance improvement it provides?
http://codereview.chromium.org/125141/diff/1003/11 File src/log.h (right): http://codereview.chromium.org/125141/diff/1003/11#newcode243 Line 243: inline static bool IsEnabled() { I think you can replace calls to Logger::IsEnabled with calls to Logger::is_enabled, and get rid of this function. http://codereview.chromium.org/125141/diff/1003/11#newcode261 Line 261: inline static bool is_enabled() { return is_enabled_; } A member function defined within the class definition is taken to be an inline member function, so "inline" is redundant here. http://codereview.chromium.org/125141/diff/1003/11#newcode344 Line 344: // VMState class implementation. A simple stack of VM states held by the I suggest to put this implementation into a log-inl.h file, as C++ Style Guide recommends: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=The_-inl.h_Files#The_-inl.h_Files http://codereview.chromium.org/125141 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
