LGTM
http://codereview.chromium.org/126198/diff/1010/1012 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/126198/diff/1010/1012#newcode133 Line 133: // Function compiles and runs, but returns a JSFunction object. Comment no longer correct? http://codereview.chromium.org/126198/diff/1010/1012#newcode336 Line 336: */ What is the commented part for? http://codereview.chromium.org/126198/diff/1010/1011 File src/x64/virtual-frame-x64.cc (right): http://codereview.chromium.org/126198/diff/1010/1011#newcode520 Line 520: Much of this code looks like it's identical to the ia32 version, except for a few lines of assembler. Would it be possible to abstract the identical parts into a shared template function so the architecture specific bits are only assembler operations? http://codereview.chromium.org/126198 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
