LGTM after comments. Please verify that the modifications do work for you, upload a new change and I can commit it for you.
-Ivan http://codereview.chromium.org/126241/diff/1/3 File SConstruct (right): http://codereview.chromium.org/126241/diff/1/3#newcode130 Line 130: ['OS_MACOSX', 'OS_MACOSX']] As far as I was told these defines are not needed. The compiler driver will set them automatically when -mmacosx-version-min is set. I verified this by building with these CPPDEFINES removed. Please remove them as we are trying to keep the amount of defines to a minimum. http://codereview.chromium.org/126241/diff/1/3#newcode654 Line 654: Thanks! http://codereview.chromium.org/126241 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
