LGTM.
http://codereview.chromium.org/126293/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/126293/diff/1/2#newcode1393 Line 1393: GenericBinaryOpStub stub(op_, overwrite_mode_, flags); You could write this: GenericBinaryFlags flags = (op_ == Token::MOD) ? SMI_CODE_IN_STUB : SMI_CODE_INLINED; http://codereview.chromium.org/126293 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
