LGTM
http://codereview.chromium.org/131029/diff/1/4 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/131029/diff/1/4#newcode216 Line 216: movq(target, code, RelocInfo::EXTERNAL_REFERENCE); // Is external reference? No, a Code object is an embedded object or code target (or possibly some third kind of target). External reference is for non-heap locations. In this case it's RelocInfo::EMBEDDED_OBJECT, to match the ia32 macro-assembler which uses Immediate(code) (always becomes embedded object for heap objects). http://codereview.chromium.org/131029 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
