Thank On Thu, Jun 18, 2009 at 4:01 PM, <[email protected]> wrote: > LGTM > > > http://codereview.chromium.org/136001/diff/1/4 > File src/heap.cc (right): > > http://codereview.chromium.org/136001/diff/1/4#newcode724 > Line 724: > Accidental edit? > > http://codereview.chromium.org/136001/diff/1/9 > File src/mark-compact.cc (right): > > http://codereview.chromium.org/136001/diff/1/9#newcode950 > Line 950: // strings are promoted to the code space, all others to the > old space. > Not your code, but this comment seems wrong. Heap numbers and > sequential strings are promoted to old data space, not code space. > > http://codereview.chromium.org/136001/diff/1/9#newcode952 > Line 952: Object* forwarded ; > Remove space before ';'. > > http://codereview.chromium.org/136001/diff/1/9#newcode1681 > Line 1681: > reinterpret_cast<OldSpace*>(space)->MCAdjustRelocationEnd(new_addr, > obj_size); > space is already has type OldSpace*, so there should be no need for the > cast? > > http://codereview.chromium.org/136001 >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
