LGTM I'm curious, what will you do with a transformed AST? Just look at it, or are you planning to implement AST builder from JSON as well?
http://codereview.chromium.org/131101/diff/1/6 File src/codegen.cc (right): http://codereview.chromium.org/131101/diff/1/6#newcode174 Line 174: PrintF(builder.BuildProgram(flit)); I'd suggest rewriting this as PrintF("%s", builder.BuildProgram(flit)) http://codereview.chromium.org/131101/diff/1/2 File src/prettyprinter.cc (right): http://codereview.chromium.org/131101/diff/1/2#newcode1183 Line 1183: Print(text); Hint: You can write Print("%*s", indent_, text) (use field width to indent with spaces). http://codereview.chromium.org/131101 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
