Reviewers: Søren Gjesse,

Description:
Sending scope types and object refs costs nothing but would save us
request that should be send to retrieve scopes informations for each
frame in 'backtrace' response.

Please review this at http://codereview.chromium.org/131107

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     src/mirror-delay.js


Index: src/mirror-delay.js
===================================================================
--- src/mirror-delay.js (revision 2220)
+++ src/mirror-delay.js (working copy)
@@ -2232,6 +2232,15 @@
    if (!IS_UNDEFINED(source_line_text)) {
      content.sourceLineText = source_line_text;
    }
+
+  content.scopes = [];
+  for (var i = 0; i < mirror.scopeCount(); i++) {
+    var scope = mirror.scope(i);
+    content.scopes.push({
+      type: scope.scopeType(),
+      ref: scope.scopeObject().handle()
+    });
+  }
  }





--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to