LGTM

http://codereview.chromium.org/141043/diff/1/5
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/141043/diff/1/5#newcode436
Line 436: elements_[i].set_static_type(element.static_type());
This has changed in ia32 (to setting the type to StaticType::unknown()).
Should change here too (and you'll get a conflict in ia32 code).

http://codereview.chromium.org/141043/diff/1/5#newcode622
Line 622: Operand(rbp, fp_relative(backing_index)));
Indentation.

http://codereview.chromium.org/141043

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to