2009/6/22 <[email protected]>: > LGTM > > > http://codereview.chromium.org/141042/diff/6/1004 > File src/jsregexp.cc (right): > > http://codereview.chromium.org/141042/diff/6/1004#newcode408 > Line 408: (IrregexpNumberOfCaptures(FixedArray::cast(jsregexp->data())) > + 1) * 2 : > Seems this have different meanings for the two implementations. > For native irregexp, it really is number of *capture* registers, but for > the interpreter it is number of registers total. > How about moving it into the branches of the conditional, so each branch > can have its own code (and properly named variables). > > http://codereview.chromium.org/141042
Unfortunately you had already LGTMed this at that point and I had committed it. However I have made a new change for your perusal (which also fixes the fact that it didn't work right on ARM). -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
