http://codereview.chromium.org/140068/diff/1007/14 File src/x64/ic-x64.cc (right):
http://codereview.chromium.org/140068/diff/1007/14#newcode188 Line 188: // -- rsp[4] : receiver On 2009/06/22 19:14:23, William Hesse wrote: > rsp[8]? Done. http://codereview.chromium.org/140068/diff/1007/15 File src/x64/register-allocator-x64.cc (right): http://codereview.chromium.org/140068/diff/1007/15#newcode50 Line 50: RelocInfo::NONE); On 2009/06/22 19:14:23, William Hesse wrote: > Could you say > CodeGeneratorScope::Current()->masm()->Move(fresh.reg(), handle()), or is there > no way to access the masm? Done. And also done for the same piece of code below. http://codereview.chromium.org/140068/diff/1007/13 File src/x64/virtual-frame-x64.cc (right): http://codereview.chromium.org/140068/diff/1007/13#newcode862 Line 862: // expects name in ecx, value in eax, and receiver on the stack. It On 2009/06/22 19:14:23, William Hesse wrote: > rcx, value in rax, Done. http://codereview.chromium.org/140068/diff/1007/13#newcode874 Line 874: // Register eax is free for value, which frees ecx for name. On 2009/06/22 19:14:23, William Hesse wrote: > Register rax ... rcx Done. http://codereview.chromium.org/140068/diff/1007/13#newcode879 Line 879: // Register ecx is free for name, which guarantees eax is free for On 2009/06/22 19:14:23, William Hesse wrote: > rcx ... rax Done. http://codereview.chromium.org/140068 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
