LGTM Hairy stuff. Do we want to do this on ARM. We should do this on x64 as well. Maybe just add TODO(x64) for now in the codegen paths that need to change?
http://codereview.chromium.org/147075/diff/1/5 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/147075/diff/1/5#newcode570 Line 570: return (scope_->num_heap_slots() > 0) Could you add a short comment explaining the reason for doing eager allocation when there are heap slots? http://codereview.chromium.org/147075/diff/1/5#newcode2187 Line 2187: // Verify that we're invoking is Function.prototype.apply. invoking is -> invoking http://codereview.chromium.org/147075/diff/1/5#newcode2263 Line 2263: // Flip the apply function and the function we to call on the stack, we to -> to http://codereview.chromium.org/147075 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
