http://codereview.chromium.org/146021/diff/1/8
File src/arm/assembler-arm-inl.h (right):

http://codereview.chromium.org/146021/diff/1/8#newcode53
Line 53: void RelocInfo::apply(int_ptr delta) {
On 2009/06/23 09:06:41, Mads Ager wrote:
> intptr_t?

Fixed to intptr_t.  ARM compilation checked.

http://codereview.chromium.org/146021/diff/1/8#newcode53
Line 53: void RelocInfo::apply(int_ptr delta) {
On 2009/06/23 10:12:16, Lasse Reichstein wrote:
> ptrdiff_t would probably be more appropriate.

 From the Internet:
"We are not even promised that ptrdiff_t is large enough to hold a
pointer,
just enough to hold a difference between two pointers within the same
object)."

I doubt that prtdiff_t is any more likely than intptr_t to be right
here.

http://codereview.chromium.org/146021

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to