Reviewers: William Hesse, Description: Revert attempt to optimize away the allocation of a temporary.
Please review this at http://codereview.chromium.org/147076 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/x64/codegen-x64.cc Index: src/x64/codegen-x64.cc =================================================================== --- src/x64/codegen-x64.cc (revision 2257) +++ src/x64/codegen-x64.cc (working copy) @@ -1404,10 +1404,12 @@ // Prepare stack for calling JS runtime function. frame_->Push(node->name()); // Push the builtins object found in the current global object. - __ movq(kScratchRegister, GlobalObject()); - __ movq(kScratchRegister, - FieldOperand(kScratchRegister, GlobalObject::kBuiltinsOffset)); - frame_->Push(kScratchRegister); + Result temp = allocator()->Allocate(); + ASSERT(temp.is_valid()); + __ movq(temp.reg(), GlobalObject()); + __ movq(temp.reg(), + FieldOperand(temp.reg, GlobalObject::kBuiltinsOffset)); + frame_->Push(&temp); } // Push the arguments ("left-to-right"). --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
