We will definitely want static type information when splitting, whether it happens with virtual frames or not. Can you measure the performance impact of this change?
On Wed, Jun 24, 2009 at 11:38 AM, <[email protected]> wrote: > > Reviewers: Erik Corry, > > Message: > Review, please. > > Description: > Removed static type inference and add a dynamic test for string > addition. > The complexity of static type inference never really paid off, and as an > > analysis it didn't fit well with codegen frame propagation. > > Please review this at http://codereview.chromium.org/146077 > > Affected files: > M src/arm/virtual-frame-arm.h > M src/frame-element.h > M src/ia32/codegen-ia32.cc > M src/ia32/virtual-frame-ia32.h > M src/ia32/virtual-frame-ia32.cc > M src/jump-target.cc > M src/register-allocator.h > M src/register-allocator.cc > M src/virtual-frame.cc > M src/x64/codegen-x64.cc > M src/x64/virtual-frame-x64.h > M src/x64/virtual-frame-x64.cc > > > > > > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
