LGTM
http://codereview.chromium.org/147201/diff/1/3 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/147201/diff/1/3#newcode5887 Line 5887: __ sar(kScratchRegister, Immediate(kSmiTagSize)); __ lea(kScratchRegister, Operand(lhs, lhs, times_1, 0)); to do it in one operation. (Add ASSERT to check that kSmiTagSize is one and kSmiTag is zero). http://codereview.chromium.org/147201/diff/1/2 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/147201/diff/1/2#newcode427 Line 427: sahf(); Add comment that sahf isn't safe to use. We should add something to CpuProbe to test its availability, and find an alternative if it doesn't exist. http://codereview.chromium.org/147201 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
