Reviewers: Lasse Reichstein, Message: Tiny review
Description: X64 implementation: Store to lookup slots Please review this at http://codereview.chromium.org/147203 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/x64/codegen-x64.cc Index: src/x64/codegen-x64.cc =================================================================== --- src/x64/codegen-x64.cc (revision 2282) +++ src/x64/codegen-x64.cc (working copy) @@ -3870,8 +3870,6 @@ // TODO(X64): Enable more types of slot. if (slot->type() == Slot::LOOKUP) { - UNIMPLEMENTED(); - /* ASSERT(slot->var()->is_dynamic()); // For now, just do a runtime call. Since the call is inevitable, @@ -3879,8 +3877,8 @@ // arguments into place. frame_->SyncRange(0, frame_->element_count() - 1); - frame_->EmitPush(esi); - frame_->EmitPush(Immediate(slot->var()->name())); + frame_->EmitPush(rsi); + frame_->EmitPush(slot->var()->name()); Result value; if (init_state == CONST_INIT) { @@ -3906,7 +3904,6 @@ // stack. This is necessary for compiling chained assignment // expressions. frame_->Push(&value); - */ } else { ASSERT(!slot->var()->is_dynamic()); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
