LGTM if you make sure you have good coverage of the generated code.
http://codereview.chromium.org/151003/diff/1/4 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/151003/diff/1/4#newcode7822 Line 7822: int CompareStub::MinorKey() { Couldn't this go into codegen.cc? http://codereview.chromium.org/151003 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
